Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group node #285

Open
SorsOps opened this issue Jun 18, 2024 · 0 comments
Open

Group node #285

SorsOps opened this issue Jun 18, 2024 · 0 comments

Comments

@SorsOps
Copy link
Member

SorsOps commented Jun 18, 2024

Group nodes as an action is currently working, however we are not saving the group at the moment as its not a core part of the graph engine.

We should add this as part of the saved serialized graph, and then hydrate the react flow nodes when loaded.

This would involve 2 steps.
1 Saving an annotation on the node identifying its parent group. This should happen on the grouping action
2. Serializing the grouping. This should happen as a finalizer for the graph.

Note that Reactflow demands that groups are defined first before other nodes. So you will need to extract the groups from the serialized nodes first and create them before the rest of the deserialization

@SorsOps SorsOps converted this from a draft issue Jun 18, 2024
@mck mck moved this to Backlog in Graph Engine Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📥 Triage
Development

No branches or pull requests

1 participant