Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Context Node #535

Open
mck opened this issue Nov 25, 2024 · 4 comments
Open

Theme Context Node #535

mck opened this issue Nov 25, 2024 · 4 comments
Assignees

Comments

@mck
Copy link
Collaborator

mck commented Nov 25, 2024

We need a node that gives us a list of all themes and their current active option in the studio context.

Image

We should use the external loader pattern to load the themes from studio. Have a look at how the external sets node works .

@SorsOps
Copy link
Member

SorsOps commented Nov 27, 2024

Notes on this:

We had issues before with dynamicism in nodes. Having inputs/outputs that can change or require a preprocessing step cause complexity.

This is definitely an impure node that requires loading information from outside of the graph system if its a standalone graph and not accepting info through the input .

This means that it has some form of runtime aspect to it which also makes it tricky to use.

@mck
Copy link
Collaborator Author

mck commented Dec 5, 2024

how do we handle deleting a mode in the system without resulting in dangling/ghost edges

@AlexBxl
Copy link
Contributor

AlexBxl commented Dec 10, 2024

Should we allow the creation of multiple Theme Context nodes?

@AlexBxl
Copy link
Contributor

AlexBxl commented Dec 11, 2024

If there are no outputs, should the node say "no theme groups" or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants