Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ts/resolveMath transforms hex transparency to NaN #336

Open
teunverhaert opened this issue Jan 10, 2025 · 0 comments · May be fixed by #337
Open

[Bug]: ts/resolveMath transforms hex transparency to NaN #336

teunverhaert opened this issue Jan 10, 2025 · 0 comments · May be fixed by #337
Assignees
@jorenbroekema
Labels
bug Something isn't working triage To be reproduced as bug

Comments

@teunverhaert
Copy link

What happened?

We describe a the opacity for a hex color value by combining color and opacity tokens (like {brand.color.primary}{core.hexopacity.80}) but the value of core.hexopacity.80 is equal to E6 and it is transformed to NaN.

Reproduction

Configurator link

You can see that --colors-primary-50 correctly returns #0000ffCC while --colors-primary-80 returns #0000ffNaN

Expected output

Hex values containing "E" should not be transformed to NaN.

Version

0.5.5
@teunverhaert teunverhaert added bug Something isn't working triage To be reproduced as bug labels Jan 10, 2025
@teunverhaert teunverhaert linked a pull request Jan 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorenbroekema jorenbroekema

Labels
bug Something isn't working triage To be reproduced as bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid checkAndEvaluateMatch returning NaN teunverhaert/sd-transforms
2 participants
@teunverhaert @jorenbroekema