Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[derive(FromRequestParts)] macro #1290

Closed
jplatte opened this issue Aug 21, 2022 · 0 comments · Fixed by #1305
Closed

Add #[derive(FromRequestParts)] macro #1290

jplatte opened this issue Aug 21, 2022 · 0 comments · Fixed by #1305
Assignees
@jplatte
Labels
A-axum-macros C-feature-request Category: A feature request, i.e: not implemented / a PR. E-medium Call for participation: Experience needed to fix: Medium / intermediate
Milestone
0.6

Comments

@jplatte
Copy link
Member

jplatte commented Aug 21, 2022 •
edited
Loading

Feature Request

Motivation

I'm pretty sure many current users of the FromRequest macro are using the resulting type as a non-terminal extractor. After #1272, this will no longer be supported.

Proposal

Add FromRequestParts macro after #1272, but before the 0.6 release.
@jplatte jplatte added C-feature-request Category: A feature request, i.e: not implemented / a PR. E-medium Call for participation: Experience needed to fix: Medium / intermediate A-axum-macros labels Aug 21, 2022
@jplatte jplatte added this to the 0.6 milestone Aug 21, 2022
@davidpdrsn davidpdrsn changed the title Feature request: FromRequestParts derive macro Add #[derive(FromRequestParts)] derive macro Aug 22, 2022
@davidpdrsn davidpdrsn changed the title Add #[derive(FromRequestParts)] derive macro Add #[derive(FromRequestParts)] macro Aug 22, 2022
@jplatte jplatte mentioned this issue Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jplatte jplatte

Labels
A-axum-macros C-feature-request Category: A feature request, i.e: not implemented / a PR. E-medium Call for participation: Experience needed to fix: Medium / intermediate
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Add #[derive(FromRequestParts)] tokio-rs/axum
1 participant
@jplatte