Graceful shutdown with hyper 1.0

[harryzcy]

• I have looked for existing issues (including closed) about this

Feature Request

Motivation

with_graceful_shutdown has been removed in hyper 1.0, not there's no convenient way to do this with axum::serve.

Proposal

Adds a with_graceful_shutdown to axum.

Alternatives

Provide an example to use hyper connections directly: hyperium/hyper#3303

[davidpdrsn]

This is something that should go in https://github.com/hyperium/hyper-util and not axum. axum doesn't know anything about the underlying transport layer so it can't implement graceful shutdown.

Have a look through hyper's issues. There might already be one, otherwise you can file a new one.

Note that axum doesn't yet support hyper 1.0 at all.

[harryzcy]

I'm tracking #1882. As hyper::Server is removed, axum::serve(listener, service) function confuses me and I initially thought the new API would provide a few more options.

This is something that should go in https://github.com/hyperium/hyper-util and not axum.

That would make sense, thanks.

[davidpdrsn]

axum::serve(listener, service) function confuses me and I initially thought the new API would provide a few more options.

The purpose of axum::serve is to get you going quickly. Not to provide lots of configurations. That belongs in hyper-util so it can be used by other libraries (such as tonic)