Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming EventLoop -> Loop #330

Closed
carllerche opened this issue Dec 23, 2015 · 7 comments
Closed

Consider renaming EventLoop -> Loop #330

carllerche opened this issue Dec 23, 2015 · 7 comments
Labels
Milestone

Comments

@carllerche
Copy link
Member

A more concise name seems nicer. This would also mean renaming EventLoopBuilder -> LoopBuilder.

@carllerche carllerche added the api label Dec 23, 2015
@carllerche carllerche added this to the v0.6 milestone Dec 23, 2015
@fhartwig
Copy link
Contributor

I prefer EventLoop. It's a bit longer than just Loop, but it's not that long and in my experience it doesn't appear often enough in any program to be worth optimising. I think that EventLoop is a bit clearer, and in my opinion that outweighs the benefits of a few saved characters.

@danburkert
Copy link

I prefer EventLoop. It's a bit longer than just Loop, but it's not that long and in my experience it doesn't appear often enough in any program to be worth optimising. I think that EventLoop is a bit clearer, and in my opinion that outweighs the benefits of a few saved characters.

I agree with this sentiment.

@fenduru
Copy link

fenduru commented Jan 15, 2016

Seems a little odd given the loop language feature

@hjr3
Copy link
Contributor

hjr3 commented Feb 24, 2016

I prefer EventLoop.

@ghost
Copy link

ghost commented Feb 24, 2016

I prefer EventLoop as well since the loop keyword is already part of the language.

@carllerche
Copy link
Member Author

Relates to #360: EventLoop may go away.

@carllerche
Copy link
Member Author

EventLoop will go away, this issue is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants