Skip to content
This repository has been archived by the owner on Sep 13, 2018. It is now read-only.

ClientProto::bind_client should return a future #132

Open
tikue opened this issue Jan 24, 2017 · 0 comments
Open

ClientProto::bind_client should return a future #132

tikue opened this issue Jan 24, 2017 · 0 comments
Labels
0.2-blocker
Milestone
0.2 release

Comments

@tikue
Copy link

tikue commented Jan 24, 2017 •
edited
Loading

Currently, ClientProto::bind_client returns a service immediately. Problems arise when a ClientProto wants to perform a handshake before beginning framing, because there's no way to propagate handshake errors. Currently, any such error ends up being swallowed and propagated upward as BrokenPipe. This could be fixed by having bind_client propagate the error returned by ClientProto::bind_transport.
@carllerche carllerche added this to the 0.2 release milestone Jan 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
0.2-blocker
Projects
None yet
Milestone
0.2 release
Development

No branches or pull requests
3 participants
@carllerche @alexcrichton @tikue