Skip to content
This repository has been archived by the owner on Sep 13, 2018. It is now read-only.

FrameBuf does not check if there is space when reading out frames #143

Open
ZoeyR opened this issue Feb 15, 2017 · 1 comment
Open

FrameBuf does not check if there is space when reading out frames #143

ZoeyR opened this issue Feb 15, 2017 · 1 comment

Comments

@ZoeyR
Copy link

ZoeyR commented Feb 15, 2017

I ran into this bug when trying to test streaming files as chunks of Vec<u8>. My program would often panic because FrameBuf would run out of capacity.

Backtrace: http://pastebin.com/6G0n2WmP
Location in code missing check: https://github.com/tokio-rs/tokio-proto/blob/master/src/streaming/multiplex/advanced.rs#L278

I realize that this had been marked TODO in the code, but there was no issue for it.

@carllerche
Copy link
Member

Thanks for the report, definitely worth having the issue tracked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants