TcpServer::serve() calls unwrap making it impossible to handle the error

[cardoe]

TcpServer::serve() calls unwrap() when bind/setting up the socket and does not return the error or let the user handle the error in anyway. A link to the line in question is here: https://github.com/tokio-rs/tokio-proto/blob/master/src/tcp_server.rs#L187

This makes it impossible to gracefully handle situations when the socket might already be in use.

[sector-f]

This strikes me as "unprofessional," for lack of a better word. That is, I can't see myself actually allowing panics to reach an end user, but apparently tokio-proto doesn't give you a choice in that matter.

[cardoe]

There's been a bunch of talk around 0.2, I'm hoping this can get addressed for that API bump.

[carllerche]

tokio-proto is on the back burner right now in favor of tokio-core (renamed tokio) and tokio. The RFC talks about this a bit. I doubt this will be fixed anytime soon as there isn't much in the way of time.