-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibly refactor AsyncBufRead #2428
Comments
For 0.3, I'd want to propose just removing the trait, and figuring it out when not under a time crunch. |
I'm still personally in favor or removing the trait and suggesting people use Seal
|
I believe that based on #2896, we will need to move |
We are going to punt on this for now. |
In the spirit of this RFC, we should consider refactoring
AsyncBufRead
in a similar way to allow unlimited peeking.It is worth noting that this removes some types' ability to implement the trait without complicating the types. This is the case for e.g.
StreamReader
. That said, as is, the trait is more or less only useful forread_line
, and other single-byte-separated splits.The text was updated successfully, but these errors were encountered: