Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document vectored IO #2578

Closed
Darksonn opened this issue Jun 1, 2020 · 2 comments
Closed

Document vectored IO #2578

Darksonn opened this issue Jun 1, 2020 · 2 comments
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-io Module: tokio/io T-docs Topic: documentation

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Jun 1, 2020

The AsyncWrite trait currently supports vectored IO through the use of poll_write_buf combined with a buffer with a useful implementation of bytes_vectored. Types such as TcpStream already support it (see here).

I guess we should also suggest or provide a buffer with a Buf impl, since the Bytes crate doesn't provide one. (Besides Chain, but it has a staticly determined number of buffers.)
@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. T-docs Topic: documentation C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate M-io Module: tokio/io labels Jun 1, 2020
@mzabaluev
Copy link
Contributor

The AsyncWrite::poll_write_buf method has been removed as per #2716.
Should this be tracked under #2692?

@Darksonn Darksonn removed the E-help-wanted Call for participation: Help is requested to fix this issue. label Oct 27, 2020
@Darksonn
Copy link
Contributor Author

Closing this for now since the situation has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-io Module: tokio/io T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Darksonn @mzabaluev