Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: investigate removing io-driver & io-readiness feature flags from Cargo.toml #2869

Closed
carllerche opened this issue Sep 23, 2020 · 4 comments · Fixed by #2881
Closed

io: investigate removing io-driver & io-readiness feature flags from Cargo.toml #2869

carllerche opened this issue Sep 23, 2020 · 4 comments · Fixed by #2881
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup.
Milestone
v0.3

Comments

@carllerche
Copy link
Member

PR #2828 added two internal feature flags. This was done to simplify the conditional compilation. Unfortunately, this can be accessed externally. It would be worth spending a moment to see if those can be removed.
@carllerche carllerche added C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate labels Sep 23, 2020
@carllerche carllerche added this to the v0.3 milestone Sep 23, 2020
@ipetkov ipetkov mentioned this issue Sep 24, 2020
Merged
@ipetkov
Copy link
Member

ipetkov commented Sep 24, 2020

@seanmonstar I see that the io-driver feature is now considered internal-only, but it used to guard things like runtime::Builder::enable_io(). Just wanted to check, do we intend for public io types to always get compiled in?

@seanmonstar
Copy link
Member

Things like enable_io should now be enabled only if one of the features that uses the IO driver is enabled, like tcp, udp, etc.

@ipetkov
Copy link
Member

ipetkov commented Sep 24, 2020

Makes sense, in that case we probably won't have a singular feature name for docs.rs (e.g. "this method is only available under X feature")?

@seanmonstar
Copy link
Member

True, documenting it will be uglier... :(

@ipetkov ipetkov mentioned this issue Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

chore: remove internal io-driver cargo feature tokio-rs/tokio
3 participants
@carllerche @seanmonstar @ipetkov