Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite chat example to not manually implement Stream #3586

Closed
Darksonn opened this issue Mar 6, 2021 · 0 comments · Fixed by #3587
Closed

Rewrite chat example to not manually implement Stream #3586

Darksonn opened this issue Mar 6, 2021 · 0 comments · Fixed by #3587
Labels
A-examples Area: The examples M-stream Module: tokio/stream T-docs Topic: documentation

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Mar 6, 2021 •
edited
Loading

We should simplify the example in examples/chat.rs to not use async-stream and not manually implement Stream. The manual Stream impl should be replaceable with use of tokio::select!.

See #3277 (comment) for context.
@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. T-docs Topic: documentation E-medium Call for participation: Experience needed to fix: Medium / intermediate M-stream Module: tokio/stream A-examples Area: The examples labels Mar 6, 2021
@aliu aliu mentioned this issue Mar 6, 2021
Merged
@Darksonn Darksonn removed E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate labels Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-examples Area: The examples M-stream Module: tokio/stream T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update chat example to use tokio::select!
1 participant
@Darksonn