-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
length_delimited refactoring #500
Comments
I would move length_delimited into tokio_utils. |
The
parts of this ticket were finished in #568. I'm working on the remaining tasks. |
This was referenced Aug 24, 2018
Thanks Eliza |
Good job Eliza! |
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is some work to be done to make the code for tokio_io::length_delimited a little bit cleaner. We need to get rid of custom Framed* types in favour of tokio_codec::Framed* types, rename length_delimited::Decoder -> Codec. Also the logic of length_delimited::Framed needs to be moved into Codec.
TODO list:
codec::length_delimited
#575)codec::length_delimited
#575)tokio_utilstokio (Movetokio_io::codec::length_delimited
module totokio::codec
#568)tokio_io::codec::length_delimited
module totokio::codec
#568)tokio_io::length_delimited::FramedWrite
#497 (Fix non-terminating loop intokio_io::length_delimited::FramedWrite
#576)tokio_io::length_delimited::FramedWrite
#497 (Fix non-terminating loop intokio_io::length_delimited::FramedWrite
#576)The text was updated successfully, but these errors were encountered: