Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

length_delimited refactoring #500

Closed
6 tasks done
kpp opened this issue Jul 20, 2018 · 5 comments
Closed
6 tasks done

length_delimited refactoring #500

kpp opened this issue Jul 20, 2018 · 5 comments

Comments

@kpp
Copy link
Contributor

kpp commented Jul 20, 2018

There is some work to be done to make the code for tokio_io::length_delimited a little bit cleaner. We need to get rid of custom Framed* types in favour of tokio_codec::Framed* types, rename length_delimited::Decoder -> Codec. Also the logic of length_delimited::Framed needs to be moved into Codec.

TODO list:

@carllerche
Copy link
Member

I would move length_delimited into tokio_utils.

@hawkw
Copy link
Member

hawkw commented Aug 24, 2018

The

  • move to tokio_utils tokio
  • mark old length_delimited as deprecated

parts of this ticket were finished in #568. I'm working on the remaining tasks.

@kpp
Copy link
Contributor Author

kpp commented Aug 25, 2018

Thanks Eliza

@kpp
Copy link
Contributor Author

kpp commented Aug 31, 2018

Good job Eliza!

@kpp kpp closed this as completed Aug 31, 2018
@hawkw
Copy link
Member

hawkw commented Aug 31, 2018

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants