-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!Send Future fails Miri check #6750
Comments
Does this still happen with #6744? It's in the master branch, but not yet a release. |
Miri still fails, Upgraded the tokio rev tag to use #6744 Test Patch: coder137/ticked-async-executor@6cc5e9d#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542 |
Like what #6744 did, I recommend filing an issue with miri. |
I'll close this for not being an issue in Tokio, but I'll be keeping an eye on the other thread. |
Version
1.38.1 and 1.39.2
Platform
Ubuntu, Windows and Mac
https://github.com/coder137/ticked-async-executor/actions/runs/10259175195
Description
Creating
TickedAsyncExecutor
to advance local async tasks only when the executor is ticked.Repo reference: https://github.com/coder137/ticked-async-executor
The tokio test(s) fail only when future provided is !Send and
join!
macro is used.Replication
Passing test when Send future is used:
Branch: https://github.com/coder137/ticked-async-executor/tree/tokio_test
Test: https://github.com/coder137/ticked-async-executor/blob/tokio_test/tests/tokio_tests.rs
CI: https://github.com/coder137/ticked-async-executor/actions/runs/10259106870
Failing test when !Send future is used:
Branch: https://github.com/coder137/ticked-async-executor/blob/tokio_test_spawn_local
Test: https://github.com/coder137/ticked-async-executor/blob/tokio_test_spawn_local/tests/tokio_tests.rs
CI: https://github.com/coder137/ticked-async-executor/actions/runs/10259175195
Failing info/logs
0_build (ubuntu-latest).txt
The text was updated successfully, but these errors were encountered: