Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need better histogram granularity #6896

Closed
rcoh opened this issue Oct 10, 2024 · 4 comments · Fixed by #6897
Closed

Need better histogram granularity #6896

rcoh opened this issue Oct 10, 2024 · 4 comments · Fixed by #6897
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-tracing Tracing support in Tokio

Comments

@rcoh
Copy link
Contributor

rcoh commented Oct 10, 2024

Is your feature request related to a problem? Please describe.
Currently, there are two histogram options:

  • Linear (uses way to much memory to have range + granularity)
  • Log (impossible to obtain good granularity because each bucket is twice as big as the previous bucket)

Describe the solution you'd like
Add a new histogram type that uses a bounded-error histogram like H2 Histogram for a reasonable accuracy-space tradeoff.

Additional context
Currently working on a pre-PR implementation, opening this issue to discuss.
@rcoh rcoh added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Oct 10, 2024
@rcoh rcoh mentioned this issue Oct 10, 2024
Merged
@Darksonn Darksonn added the M-tracing Tracing support in Tokio label Oct 11, 2024
@rcoh
Copy link
Contributor Author

rcoh commented Oct 17, 2024 •
edited
Loading

Fixed by #6897 (edited)

@Darksonn
Copy link
Contributor

Are you able to clarify? Did you mean to link to something different?

@rcoh
Copy link
Contributor Author

rcoh commented Oct 18, 2024

Yeah, sorry meant to link to my CR. Not sure what happened.

@Darksonn
Copy link
Contributor

I updated your PR so that it will auto-close this issue when merged.

@hds hds closed this as completed in #6897 Oct 21, 2024
@drbrain drbrain mentioned this issue Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-tracing Tracing support in Tokio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: add H2 Histogram option to improve histogram granularity rcoh/tokio
2 participants
@rcoh @Darksonn