Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial shows table of contents on Kindle, takes space from code, easy to select accidentally #745

Open
proski opened this issue Jan 16, 2024 · 1 comment

Comments

@proski
Copy link
Contributor

proski commented Jan 16, 2024

The table of contents is always shown on two Amazon Kindle devices I'm using to read the tutorial. One is Kindle Oasis with 7" screen, another is Kindle Fire HD with 10" screen.

Even though the screen on those devices is wider than on mobile phones, it's still not wide enough to show the TOC and the page contents comfortably. The code examples don't fit the width of the text. I would prefer to have the TOC in a pull-down menu on top like it's shown on phones.

Another issue with TOC on books readers is that it's very easy to click on links accidentally while holding the device.

I'm attaching a screenshot of a narrow Chromium window to illustrate the issue.

tokio-screenshot

I wish Tokio would just use mdbook for the tutorial. It would solve both this issue and the dark theme issue.

@proski
Copy link
Contributor Author

proski commented Jan 17, 2024

$tablet in styles/styles.scss should be 1060px or so (not 600px) to accommodate all code and most comments up to position 72 for monospaced font in the narrowest window with side menu.

$navbar-breakpoint can be less than 1060px, but 600px is too small. 650px would work better, that way Learn doesn't get behind Tokio before disappearing.

By the way, the vertical bar between Blog and the Twitter icon in navbar disappears below the $tablet width, shifting "API Docs" and "Blog" upwards above "Learn".

Disclaimer: I'm not a web developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant