-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
span_marker
1.6.0: Add missing sklearn
(scikit-learn
) dependency
#69
Comments
span_marker
1.6.0: Add missing sklearn
dependencyspan_marker
1.6.0: Add missing sklearn
(scikit-learn
) dependency
Hmm, that's odd. I believe sklearn is an indirect required dependency due to
|
@tomaarsen These are the dependencies my resolver (uv) finds:
|
@tomaarsen So apparently, some old version of seqeval gets selected. |
@tomaarsen I see you don't have version constraints set in your The proper fix is to remove all transitive dependencies like scikit-learn from your distribution package's You can simply run |
@tomaarsen BTW, using Creosote you can detect unused dependencies (not used directly by your own package). |
I indeed don't have lower bounds for all dependencies - I didn't have time to look into from which versions my features started working. This is indeed not ideal. Having said that, although sklearn is an indirect dependency according to my
|
@tomaarsen The Python Zen: it's better to ask forgiveness than permission. Why not just require modern versions as a lower bound, and then relaxing the bound as issues are filed on this? Chances are, you will have to make minimal adjustments. |
The text was updated successfully, but these errors were encountered: