Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Add bundle install retry feature #96

Open
comjf opened this issue Nov 11, 2013 · 3 comments
Open

Add bundle install retry feature #96

comjf opened this issue Nov 11, 2013 · 3 comments

Comments

@comjf
Copy link

comjf commented Nov 11, 2013

Sometimes the RubyGem service returns a lot of 503s (happened to me today for about 3 hours on different gems) and the deploy:setup phase wipes the whole directory if it fails, making you start from scratch.

I propose a change that allows commands to be rerun if desired. I wrote up a patch but had 2 errors in testing it.

  1. when I do vagrant up I get
    The box you attempted to add doesn't match the provider you specified.

Provider expected: virtualbox
Provider of box: vmware_fusion

  1. rspec seems to have 1 error, but I think it's just a mocking issue. Where does mocka actually store it's mocks so I can modify it?

My commit can be found here: tkwwarchive@e547f84

Thank you,
James Flowers

@comjf
Copy link
Author

comjf commented Nov 18, 2013

@tomafro Any ideas?

@tomafro
Copy link
Owner

tomafro commented Nov 18, 2013

I think being able to retry gem installation will be valuable, particularly given how flaky github and rubygems seem to be. Luckily though, we can add it without any (real) code. The latest bundler (pre-release) adds a --retry flag, so once that's been released, I'll add that to the recipe. (see here: rubygems/bundler#2601)

As for the vagrant problem, I'm amazed you went to the effort of running the tests - well done! As you've probably figures out though, I wrote them using the vmware fusion adapter for vagrant, not bog-standard vagrant. I'll look into getting them running on both.

@comjf
Copy link
Author

comjf commented Dec 5, 2014

@tomafro is there an update? This has been released a while ago.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants