Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling multisampling returns error when it shouldn't. #575

Closed
TyOverby opened this issue Aug 20, 2015 · 22 comments · Fixed by #590
Closed

Enabling multisampling returns error when it shouldn't. #575

TyOverby opened this issue Aug 20, 2015 · 22 comments · Fixed by #590

Comments

@TyOverby
Copy link
Contributor

Only recently, when I use with_multisampling in my glutin/glium project I get the error `Couldn't find any pixel format that matches the criterias.'

This never used to happen before, and in fact, multisampling is supported (and worked) on the computer that I'm testing on!

@tomaka tomaka added the bug label Aug 21, 2015
@tomaka
Copy link
Contributor

tomaka commented Aug 21, 2015

On which platform?

@TyOverby
Copy link
Contributor Author

Linux

@tomaka tomaka added the A-x11 label Aug 21, 2015
@paulrouget
Copy link
Contributor

Could it be because of #569 ?

@tomaka
Copy link
Contributor

tomaka commented Aug 21, 2015

Chances are that #569 in fact fixes it.
I just published version 0.3.5, which includes #569.

@TyOverby
Copy link
Contributor Author

I'll check and then report back

@TyOverby
Copy link
Contributor Author

I updated to glutin 0.3.5 and glium 0.8.5 and the error is still returned.

@tomaka
Copy link
Contributor

tomaka commented Aug 21, 2015

What does glxinfo say?

@TyOverby
Copy link
Contributor Author

Glxinfo dump: http://pastebin.com/raw.php?i=kizztzDX

@TyOverby
Copy link
Contributor Author

Does anything look suspicious?

@tomaka
Copy link
Contributor

tomaka commented Aug 29, 2015

Oh I forgot about this issue.

The problem is that all your pixelformats will multisampling enabled are "non-conformant" (the Ncon in the last column means that).
Glutin automatically filters them out: https://github.com/tomaka/glutin/blob/b8b1b80631e1335a7ab747f34e1c67dfa0790a10/src/api/glx/mod.rs#L387-L390

I don't know what the best solution to this problem is. Should this be "won't fix" or shoud glutin accept non-conformant formats?

@TyOverby
Copy link
Contributor Author

So the implementation is non-conformant but it just happens to work anyways?

Would it be possible to ask Glutin to "force" non-compat formats? Like I said in the issue, multi-sampling worked fine before you checked for conformance.

I don't know how other devs do it, but I get multisampling on all the games that I play on this computer somehow.

@TyOverby
Copy link
Contributor Author

@tomaka Could you reopen this issue? I'm still getting the same error as before.

@tomaka tomaka reopened this Oct 12, 2015
@dbarnhart
Copy link

I'm also getting this issue.
glxinfo.dump.txt

@c0gent
Copy link

c0gent commented May 16, 2016

Just started getting this same error as of v0.14.
glxinfo: http://pastebin.com/gYPW90gm

Perhaps a window builder setting to force/allow non-conformant modes?

@TyOverby
Copy link
Contributor Author

I'm still getting this error.

@c0gent
Copy link

c0gent commented Jun 4, 2016

Working again now.

@jrmiller82
Copy link

Still getting this issue.

@no-longer-on-githu-b
Copy link

I can still reproduce this.

@Cxarli
Copy link

Cxarli commented May 2, 2018

Not 100% sure it is related, but this might be fixed with the 18.* version of Mesa. (See PistonDevelopers/piston#1202 for more information.)

@goddessfreya
Copy link
Contributor

Can you guys still reproduce this, or has it been fixed?

@goddessfreya
Copy link
Contributor

Assuming fixed. Reopen if not the case.

@Syntaxxor
Copy link

I don't know if this will reopen, but I can say that I'm able to reproduce this on the latest version with an Intel HD Graphics 4000 device. Chances are, it's just because my laptop and integrated graphics are old, but it's still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

10 participants