Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL Params do not work as expected for flag type params #258

Closed
DeWarner opened this issue Jun 9, 2022 · 1 comment · Fixed by #259
Closed

URL Params do not work as expected for flag type params #258

DeWarner opened this issue Jun 9, 2022 · 1 comment · Fixed by #259

Comments

@DeWarner
Copy link
Contributor

DeWarner commented Jun 9, 2022 •
edited
Loading

get_param("reverse") does not return Some("") as expected for query string ?reverse
The expected behavior for URLParams is to treat params with no = in them as if the same as an empty value
localhost:80/api/users?reverse should be equivalent to localhost:80/api/users?reverse=

reference:
https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams#empty_value_vs._no_value
@DeWarner DeWarner mentioned this issue Jun 9, 2022
Merged
@DeWarner
Copy link
Contributor Author

DeWarner commented Jun 9, 2022

PR ready for review #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for flag type params with no value DeWarner/rouille
1 participant
@DeWarner