Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supporting DataContract/DataMember/IgnoreDataMember #66

Open
BrannonKing opened this issue Aug 2, 2017 · 1 comment
Open

supporting DataContract/DataMember/IgnoreDataMember #66

BrannonKing opened this issue Aug 2, 2017 · 1 comment

Comments

@BrannonKing
Copy link

I attempted to write my own inheritor of IDynamicTypeSerializer for handling DataContract objects. It would be very similar to the GenericSerializer. Some things that caused me a problem: the Serializer.Settings and Serializer.GetIndirectData are both internal, making it impossible for me to duplicate the mechanism in GenericSerializer. It would be nice if GenericSerializer wasn't sealed and had virtual methods for GetFieldInfos and Handles.

@tomba
Copy link
Owner

tomba commented Aug 2, 2017

Yes, I never really finished the mechanism to create custom serializers. I didn't want to make all the stuff public, as I felt it's exposing too much internal data, but as you noticed, at least some of it is needed. But if I recall right, I didn't consider making GenericSerializer inheritable. I was only thinking of how a user could write a serializer from scratch. Perhaps making GenericSerializer inheritable would be an easier step forward.

However, I haven't done any .Net development for a long time, so I don't think I'll work on this any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants