fix(Marker): allow null and undefined as children #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful is you have code like the following:
``js
<Marker {...props}>
{ showInfo &&
<InfoWindow content="Some Info" />
}
</Marker>
```
Right now, this will throw an `Error` about being unable to read `props` of `undefined`, so you have to use the following workaround (not ideal):
```js
// workaround:
<Marker {...props}>
{ showInfo ?
<InfoWindow content="Some Info" />
: <noscript />
}
</Marker>
```
|
Thanks. Released v2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful if you have code like the following:
Right now, this will throw an
Errorabout being unable to readpropsofundefined, so you have to use the following workaround (not ideal):With this change, the workaround is no longer needed and the first example works as expected 😄