Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for React 16 #677

Closed
msmfsd opened this issue Oct 24, 2017 · 5 comments
Closed

Support for React 16 #677

msmfsd opened this issue Oct 24, 2017 · 5 comments
Labels
feature request: PRs welcomed identified bug: submit PRs?

Comments

@msmfsd
Copy link

msmfsd commented Oct 24, 2017

Upgrading react and react-dom to v16.0.0 gets following error:

Module not found: Error: Can't resolve 'react/lib/React' in '/app/node_modules/react-google-maps/node_modules/react-dom/lib'
@tomchentw
Copy link
Owner

@msmfsd which module throws this error?

@msmfsd
Copy link
Author

msmfsd commented Oct 26, 2017

@tomchentw I get it with react-google-maps@4.11.0

@msmfsd
Copy link
Author

msmfsd commented Oct 26, 2017

its a webpack compile

@tomchentw
Copy link
Owner

@msmfsd 4.11.0 is old and not supported anymore. Please try upgrading to latest version:
https://github.com/tomchentw/react-google-maps/releases/tag/v9.0.3

You can find changelogs here:
https://github.com/tomchentw/react-google-maps/blob/master/CHANGELOG.md

Thanks!

@tomchentw tomchentw mentioned this issue Oct 26, 2017
Merged
@tomchentw
Copy link
Owner

Released v9.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request: PRs welcomed identified bug: submit PRs?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomchentw @msmfsd