Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rectangle shape #80

Closed

Conversation

alistairjcbrown
Copy link

Adds in a new Rectangle shape with available bounds_changed event.

This should fix issue #79

import { Rectangle } from 'react-google-maps';

let bounds = new google.maps.LatLngBounds(
  new google.maps.LatLng(-34.04355650412745, 150.99609375),
  new google.maps.LatLng(-33.68321092658006, 151.4300537109375)
);

<Rectangle
  ref="shape"
  clickable={true}
  draggable={true}
  editable={true}
  onBoundsChanged={() => {
    console.log('Bounds changed');
  }}
  bounds={bounds} />

@alistairjcbrown
Copy link
Author

Hi @tomchentw - give me a shout if there's anything else needed for this PR.
it should be a fairly minimal change (most of the diff is the built files) and just adds the Rectangle shape in the same was as the Circle.

@alistairjcbrown
Copy link
Author

Hi @tomchentw - just thought I'd give this PR a bump - is this good to be merged?

@tomchentw
Copy link
Owner

TODO: add this in #88

@tomchentw
Copy link
Owner

Hi @alistairjcbrown , sorry for the late response.
I took a day to rewrite the module from scratch on #88 . It will be great if you could take a look at it. Thanks!

tomchentw added a commit that referenced this pull request Aug 7, 2015
tomchentw added a commit that referenced this pull request Aug 7, 2015
tomchentw added a commit that referenced this pull request Aug 7, 2015
@tomchentw tomchentw closed this in 4511d87 Aug 7, 2015
@tomchentw
Copy link
Owner

Released v2.0.0 and v2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants