Fix overlay view not rendering correctly #99
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I recently upgraded to the latest version of react-google-maps and my
OverlayView
s stopped working. They would mysteriously cluster at the origin of the map:After adding the position property to the whitelist of component properties (although admittedly in the post-babel distribution code in my node_modules folder) they spring into life again:
This was made a little trickier to debug because the
_getPixelPosition
method doesn't complain if it cannot get a projection or a position for theOverlayView
. It would probably be worth taking this change one step further and adding a warning if theif (projection && position) {
condition does not match.Cheers,
~ Si