Merge branch 'issue609' of https://github.com/bentglasstube/Perl-Critic into bentglasstube-issue609

Conflicts:
	Changes

Author: thaljef

Changes

@@ -1,5 +1,9 @@
 Revision history for Perl module Perl::Critic
 
+    [New Policies]
+    * Added a policy: ControlStructures::ProhibitYadaOperator - Never use ...
+      in production code.
+
     [Miscellanea]
     * Add more strict/warnings importer modules.
 

MANIFEST

@@ -78,6 +78,7 @@ lib/Perl/Critic/Policy/ControlStructures/ProhibitPostfixControls.pm
 lib/Perl/Critic/Policy/ControlStructures/ProhibitUnlessBlocks.pm
 lib/Perl/Critic/Policy/ControlStructures/ProhibitUnreachableCode.pm
 lib/Perl/Critic/Policy/ControlStructures/ProhibitUntilBlocks.pm
+lib/Perl/Critic/Policy/ControlStructures/ProhibitYadaOperator.pm
 lib/Perl/Critic/Policy/Documentation/PodSpelling.pm
 lib/Perl/Critic/Policy/Documentation/RequirePackageMatchesPodName.pm
 lib/Perl/Critic/Policy/Documentation/RequirePodAtEnd.pm
@@ -291,6 +292,7 @@ t/ControlStructures/ProhibitPostfixControls.run
 t/ControlStructures/ProhibitUnlessBlocks.run
 t/ControlStructures/ProhibitUnreachableCode.run
 t/ControlStructures/ProhibitUntilBlocks.run
+t/ControlStructures/ProhibitYadaOperator.run
 t/Documentation/RequirePackageMatchesPodName.run
 t/Documentation/RequirePodAtEnd.run
 t/Documentation/RequirePodLinksIncludeText.run

lib/Perl/Critic/Policy/ControlStructures/ProhibitYadaOperator.pm

@@ -0,0 +1,98 @@
+package Perl::Critic::Policy::ControlStructures::ProhibitYadaOperator;
+
+use 5.006001;
+use strict;
+use warnings;
+use Readonly;
+
+use Perl::Critic::Utils qw{ :characters :severities };
+use base 'Perl::Critic::Policy';
+
+our $VERSION = '1.123';
+
+#-----------------------------------------------------------------------------
+
+Readonly::Scalar my $DESC => q{yada operator (...) used};
+Readonly::Scalar my $EXPL => q{The yada operator is a placeholder for code you have not yet written.};
+
+#-----------------------------------------------------------------------------
+
+sub supported_parameters { return ()                         }
+sub default_severity     { return $SEVERITY_HIGH             }
+sub default_themes       { return qw( core pbp maintenance ) }
+sub applies_to           { return 'PPI::Token::Operator' }
+
+#-----------------------------------------------------------------------------
+
+sub violates {
+    my ( $self, $elem, undef ) = @_;
+
+    if ( _is_yada( $elem ) ) {
+        return $self->violation( $DESC, $EXPL, $elem );
+    }
+    return;    #ok!
+}
+
+sub _is_yada {
+    my ( $elem ) = @_;
+
+    return if $elem ne '...';
+    #return if not defined $elem->statement;
+
+    # if there is something significant on both sides of the element it's
+    # probably the three dot range operator
+    return if ($elem->snext_sibling and $elem->sprevious_sibling);
+
+    return 1;
+}
+
+1;
+
+__END__
+
+#-----------------------------------------------------------------------------
+
+=pod
+
+=head1 NAME
+
+Perl::Critic::Policy::ControlStructures::ProhibitYadaOperator - Never use C<...> in production code.
+
+=head1 AFFILIATION
+
+This Policy is part of the core L<Perl::Critic|Perl::Critic>
+distribution.
+
+
+=head1 DESCRIPTION
+
+The yada operator C<...> is not something you'd want in production code but
+it is perfectly useful less critical environments.
+
+=head1 CONFIGURATION
+
+This Policy is not configurable except for the standard options.
+
+
+=head1 AUTHOR
+
+Alan Berndt <alan@eatabrick.org>
+
+=head1 COPYRIGHT
+
+Copyright (c) 2015 Alan Berndt.  All rights reserved.
+
+This program is free software; you can redistribute it and/or modify
+it under the same terms as Perl itself.  The full text of this license
+can be found in the LICENSE file included with this module.
+
+=cut
+
+# Local Variables:
+#   mode: cperl
+#   cperl-indent-level: 4
+#   fill-column: 78
+#   indent-tabs-mode: nil
+#   c-indentation-style: bsd
+# End:
+# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :

t/ControlStructures/ProhibitYadaOperator.run

@@ -0,0 +1,49 @@
+## name Basic passing
+## failures 0
+## cut
+
+for (1 ... 3) {
+    do_something();
+}
+
+for ('a' ... 'b') {
+    do_something();
+}
+
+#-----------------------------------------------------------------------------
+
+## name Basic failure
+## failures 1
+## cut
+
+do_something();
+
+...
+
+do_something();
+
+#-----------------------------------------------------------------------------
+
+## name Excessive yadaing
+## failures 1
+## cut
+
+do_something();
+
+...
+...
+...
+...
+
+do_something();
+
+#-----------------------------------------------------------------------------
+
+# Local Variables:
+#   mode: cperl
+#   cperl-indent-level: 4
+#   fill-column: 78
+#   indent-tabs-mode: nil
+#   c-indentation-style: bsd
+# End:
+# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :