All recommended/optional dependencies are now required.

This ensures a consistent & optimal experience for all users.
Also, it makes our code a lot simpler since we don't have to
generate wrappers that run all the tests without the optional
modules.

Generally speaking, I feel we should avoid recommended/optional
dependencies unless there is a really compelling reason to
permit users to not have them (like because they don't work
on certain platforms or perls).

Author: thaljef

.gitignore

@@ -16,9 +16,6 @@ tags
 cover_db
 lib/Perl/Critic/PolicySummary.pod
 nytprof*
-t/*_without_optional_dependencies.t
 t/ControlStructures/ProhibitNegativeExpressionsInUnlessAndUntilConditions.run
 t/NamingConventions/Capitalization.run
 t/Variables/RequireLocalizedPunctuationVars.run
-xt/author/generated/t/*_without_optional_dependencies.t
-xt/author/generated/xt/author/*_without_optional_dependencies.t

Build.PL

@@ -12,11 +12,8 @@ use lib 'inc';
 use Perl::Critic::BuildUtilities qw<
     required_module_versions
     build_required_module_versions
-    recommended_module_versions
-    test_wrappers_to_generate
-    get_PL_files
-    dump_unlisted_or_optional_module_versions
     emit_tar_warning_if_necessary
+    get_PL_files
 >;
 use Perl::Critic::Module::Build;
 
@@ -36,7 +33,6 @@ my $builder = Perl::Critic::Module::Build->new(
 
     requires            => { required_module_versions() },
     build_requires      => { build_required_module_versions() },
-    recommends          => { recommended_module_versions() },
 
     # Don't require a developer version of Module::Build, even if the
     # distribution tarball was created with one.  (Oops.)
@@ -86,14 +82,11 @@ my $builder = Perl::Critic::Module::Build->new(
             README
         >,
         values %{ get_PL_files() },
-        test_wrappers_to_generate(),
     ],
 );
 
 $builder->create_build_script();
 
-dump_unlisted_or_optional_module_versions();
-
 
 ##############################################################################
 # Local Variables:

Changes

@@ -7,6 +7,10 @@ Revision history for Perl module Perl::Critic
       Also now requires Readonly-2.00, which obviates the need for Readonly::XS
       to get fast constants.
 
+    * File::HomeDir, File::Which, and Term::ANSIColor are all required now
+      instead of being optional or recommended. This simplifies our test code
+      and ensures consistent optimal behavior for all users.
+
     [New Policies]
     * Added two new policies: BuiltinFunctions::ProhibitUselessTopic and
       RegularExpressions::ProhibitUselessTopic.

MANIFEST

@@ -214,9 +214,6 @@ lib/Test/Perl/Critic/Policy.pm
 LICENSE
 Makefile.PL
 MANIFEST			This list of files
-META.json
-META.yml
-README
 README.md
 t/00_modules.t
 t/01_bad_perlcriticrc
@@ -425,4 +422,6 @@ xt/author/94_includes.t
 xt/author/95_kwalitee.t
 xt/author/98_pod_syntax.t
 xt/author/99_pod_coverage.t
-xt/author/generate_without_optional_dependencies_wrappers.PL
+README
+META.yml
+META.json

inc/Perl/Critic/BuildUtilities.pm

@@ -6,18 +6,15 @@ use warnings;
 
 use English q<-no_match_vars>;
 
-our $VERSION = '1.116';
+our $VERSION = '1.122';
 
 use Exporter 'import';
 
 our @EXPORT_OK = qw<
     required_module_versions
     build_required_module_versions
-    recommended_module_versions
-    test_wrappers_to_generate
-    get_PL_files
-    dump_unlisted_or_optional_module_versions
     emit_tar_warning_if_necessary
+    get_PL_files
 >;
 
 
@@ -35,10 +32,12 @@ sub required_module_versions {
         'Exporter'                      => 5.63,
         'File::Basename'                => 0,
         'File::Find'                    => 0,
+        'File::HomeDir'                 => 0,
         'File::Path'                    => 0,
         'File::Spec'                    => 0,
         'File::Spec::Unix'              => 0,
         'File::Temp'                    => 0,
+        'File::Which'                   => 0,
         'Getopt::Long'                  => 0,
         'IO::String'                    => 0,
         'IPC::Open2'                    => 1,
@@ -64,6 +63,7 @@ sub required_module_versions {
         'Scalar::Util'                  => 0,
         'String::Format'                => 1.13,
         'Task::Weaken'                  => 0,
+        'Term::ANSIColor'               => '2.02',
         'Test::Builder'                 => 0.92,
         'Text::ParseWords'              => 3,
         'base'                          => 0,
@@ -85,62 +85,6 @@ sub build_required_module_versions {
 }
 
 
-sub recommended_module_versions {
-    return (
-        'File::HomeDir'         => 0,
-
-        # If the following changes, the corresponding change needs to be made
-        # in $Perl::Critic::Utils::Constants::_MODULE_VERSION_TERM_ANSICOLOR.
-        'Term::ANSIColor'       => '2.02',
-
-        # All of these are for Documentation::PodSpelling
-        'File::Which'           => 0,
-    );
-}
-
-
-sub test_wrappers_to_generate {
-    my @tests_to_be_wrapped = qw<
-        t/00_modules.t
-        t/01_config.t
-        t/01_config_bad_perlcriticrc.t
-        t/01_policy_config.t
-        t/02_policy.t
-        t/03_pragmas.t
-        t/04_options_processor.t
-        t/05_utils.t
-        t/05_utils_ppi.t
-        t/05_utils_pod.t
-        t/06_violation.t
-        t/07_command.t
-        t/07_perlcritic.t
-        t/08_document.t
-        t/09_theme.t
-        t/10_user_profile.t
-        t/11_policy_factory.t
-        t/12_policy_listing.t
-        t/12_theme_listing.t
-        t/13_bundled_policies.t
-        t/14_policy_parameters.t
-        t/15_statistics.t
-        t/20_policies.t
-        t/20_policy_pod_spelling.t
-        t/20_policy_prohibit_evil_modules.t
-        t/20_policy_prohibit_hard_tabs.t
-        t/20_policy_prohibit_trailing_whitespace.t
-        t/20_policy_require_consistent_newlines.t
-        t/20_policy_require_tidy_code.t
-        xt/author/80_policysummary.t
-        t/92_memory_leaks.t
-        xt/author/94_includes.t
-    >;
-
-    return
-        map
-            { "xt/author/generated/${_}_without_optional_dependencies.t" }
-            @tests_to_be_wrapped;
-}
-
 my @TARGET_FILES = qw<
     t/ControlStructures/ProhibitNegativeExpressionsInUnlessAndUntilConditions.run
     t/NamingConventions/Capitalization.run
@@ -150,41 +94,9 @@ my @TARGET_FILES = qw<
 sub get_PL_files {
     my %PL_files = map { ( "$_.PL" => $_ ) } @TARGET_FILES;
 
-    $PL_files{'xt/author/generate_without_optional_dependencies_wrappers.PL'} =
-        [ test_wrappers_to_generate() ];
-
     return \%PL_files;
 }
 
-sub dump_unlisted_or_optional_module_versions {
-    print
-        "\nVersions of optional/unlisted/indirect dependencies:\n\n";
-
-    my @unlisted_modules = (
-        qw<
-        >,
-        keys %{ { recommended_module_versions() } },
-    );
-
-    foreach my $module (sort @unlisted_modules) {
-        my $version;
-
-        eval "use $module; \$version = \$${module}::VERSION;";
-
-        if ($EVAL_ERROR) {
-            $version = 'not installed';
-        } elsif (not defined $version) {
-            $version = 'undef';
-        }
-
-        print "    $module = $version\n";
-    }
-
-    print "\n";
-
-    return;
-}
-
 sub emit_tar_warning_if_necessary {
     if ( os_is( qw<Solaris> ) ) {
         print <<'END_OF_TAR_WARNING';
@@ -220,18 +132,6 @@ Various utilities used in assembling Perl::Critic, primary for use by
 
 =over
 
-=item C<recommended_module_versions()>
-
-Returns a hash mapping between recommended (but not required) modules
-for Perl::Critic and the minimum version required of each module,
-
-
-=item C<test_wrappers_to_generate()>
-
-Returns a list of test wrappers to be generated by
-F<xt/author/generate_without_optional_dependencies_wrappers.PL>.
-
-
 =item C<get_PL_files()>
 
 Returns a reference to a hash with a mapping from the name of a .PL

lib/Perl/Critic.pm

@@ -876,10 +876,14 @@ L<Email::Address|Email::Address>
 
 L<Exception::Class|Exception::Class>
 
+L<File::HomeDir|File::HomeDir>
+
 L<File::Spec|File::Spec>
 
 L<File::Spec::Unix|File::Spec::Unix>
 
+L<File::Which|File::Which>
+
 L<IO::String|IO::String>
 
 L<List::MoreUtils|List::MoreUtils>
@@ -908,19 +912,13 @@ L<String::Format|String::Format>
 
 L<Task::Weaken|Task::Weaken>
 
+L<Term::ANSIColor|Term::ANSIColor>
+
 L<Text::ParseWords|Text::ParseWords>
 
 L<version|version>
 
 
-The following modules are optional, but recommended for complete
-functionality:
-
-L<File::HomeDir|File::HomeDir>
-
-L<File::Which|File::Which>
-
-
 =head1 CONTACTING THE DEVELOPMENT TEAM
 
 You are encouraged to subscribe to the mailing list; send a message to