Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the item module public #2

Open
ElSamhaa opened this issue Jun 27, 2024 · 0 comments
Open

Make the item module public #2

ElSamhaa opened this issue Jun 27, 2024 · 0 comments

Comments

@ElSamhaa
Copy link

ElSamhaa commented Jun 27, 2024

Hello, thanks for forking and continuing the development of Skim.

I'm attempting to utilize Skim as a library without its UI. However, I encountered an issue when building the engine with the correct default criterion similar to what Skim uses in its binary. It seems that the item module is marked as private, preventing me from implementing something like this:

use skim::prelude::{item::{RankBuilder, RankCriteria}, *};

//...

  let search_factory = ExactOrFuzzyEngineFactory::builder()
    .rank_builder(Arc::new(RankBuilder::new(vec![
      RankCriteria::Score,
      RankCriteria::Begin,
      RankCriteria::End,
    ])))
    .build();
error[E0603]: module `item` is private

lotabout/skim#568
sayanarijit/xplr#678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant