Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Ramda? #1

Open
markerikson opened this issue Jul 20, 2017 · 1 comment
Open

Remove dependency on Ramda? #1

markerikson opened this issue Jul 20, 2017 · 1 comment

Comments

@markerikson
Copy link

I see that immutable-ops depends on Ramda. But, inspecting the source, it looks like only two Ramda functions are actually being used: curry and placeholder.

Would it be possible to replace those two functions with homebuilt equivalents, and remove the dependency on Ramda? It's a great library, but not everyone is using it, and I assume this would enable smaller bundle sizes.

@ahutchings
Copy link

ahutchings commented May 30, 2019

I was just looking into bundle optimizations for my app and noticed this as well. Ramda has added the package.json sideEffects field in 0.26.0 and is now tree-shakable by webpack and rollup.

Now that that's available, we could also get the benefit of smaller builds by upgrading ramda.

@markerikson @haveyaseen are you all okay with this direction? I can put a PR together.

Edit: Oops, I see now that ramda was upgraded to 0.26 in #2. Can this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants