Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go modules v2 compatibility #15

Closed
invidian opened this issue Oct 31, 2020 · 1 comment
Closed

Go modules v2 compatibility #15

invidian opened this issue Oct 31, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@invidian
Copy link

Short summary

As latest released version at the time of writing is v2.2.0, which do not include v2 subdirectory, currently running go get -u github.com/tommy-muehle/go-mnd/cmd/mnd pulls latest v1 version (v1.3.0), as it is by design with Go modules.

This may lead to confusion, as many users may user older version, without access to new features.

Steps to reproduce the behavior

Run go get -u github.com/tommy-muehle/go-mnd/cmd/mnd on a fresh system.

Go version (output of 'go version')

go version go1.15.3 linux/amd64

Operating system / Environment

$ cat /etc/os-release
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://www.archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
LOGO=archlinux

Expected behavior

Documented go get -u github.com/tommy-muehle/go-mnd/cmd/mnd and all imports should be changed to github.com/tommy-muehle/go-mnd/v2/cmd/mnd, including go.mod, so latest version is pulled.

This can be used as an example to follow: kubernetes/klog@2bed4d0#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

@tommy-muehle tommy-muehle self-assigned this Jan 22, 2021
@tommy-muehle tommy-muehle added the bug Something isn't working label Jan 22, 2021
@tommy-muehle
Copy link
Owner

@invidian Thank you very much for the report! You're totally right. I missed that. It's fixed with this commit I'll soon release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants