Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make percentage input consistent #188

Open
s3cur3 opened this issue Dec 16, 2024 · 0 comments · May be fixed by tompave/fun_with_flags_ui#43
Open

Make percentage input consistent #188

s3cur3 opened this issue Dec 16, 2024 · 0 comments · May be fixed by tompave/fun_with_flags_ui#43

Comments

@s3cur3
Copy link

s3cur3 commented Dec 16, 2024

Hi there! Long-time happy FunWithFlags user here. ☺️

I recently started using the Percentage feature, and found the input somewhat error prone. For instance:

image

In the input field, I'd call a value between 0 and 1 a "ratio" or maybe "proportion" of users. Furthermore, the fact that previously-submitted values get displayed as an actual percentage ("5.0%") while new inputs must be a ratio makes it easy to accidentally scan the page and try to input, say, 10 to update the percentage.

To my mind, the right thing to do here is to accept input in the range (0, 100) while storing it in the database as the ratio [percentage] / 100. I'm happy to put together a PR if this is something you'd like addressed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant