Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conn.script_name instead of namespace to construct paths #12

Open
LostKobrakai opened this issue Jun 23, 2019 · 3 comments · May be fixed by #17
Open

Use conn.script_name instead of namespace to construct paths #12

LostKobrakai opened this issue Jun 23, 2019 · 3 comments · May be fixed by #17

Comments

@LostKobrakai
Copy link
Contributor

I'm currently working on a similar "embed into some phoenix/plug app" tool than this one. In my research I found in bamboos preview router that they use conn.script_name to construct their routes. It would be nice to use this here as well, so the namespace option is no longer needed.

@tompave
Copy link
Owner

tompave commented Jun 23, 2019

Hi, thank you for the suggestion.

I wasn't familiar with conn.script_name, but it looks a bit magical and not well documented.
Looking at the code, it seems to be set in plug and phoenix when forwarding in the router, but I can't tell whether it should be considered a private detail.

Do you have more info?

@LostKobrakai
Copy link
Contributor Author

Not really. I've looked at when it was introduces, and it seems to be there since Plug.Conn became a struct (basically forever). A quick look just now also suggests the route helpers of phoenix router do use the field, so I'd expect it's fine to be used for that job.

@tompave
Copy link
Owner

tompave commented Jun 23, 2019

Ok, I see. Then I'd be happy to accept a PR for this, if you want to give it a go.

The main requirement is that the dashboard should still work in three cases: embedded in Phoenix, embedded in another Plug router, and standalone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants