-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use conn.script_name instead of namespace to construct paths #12
Comments
Hi, thank you for the suggestion. I wasn't familiar with Do you have more info? |
Not really. I've looked at when it was introduces, and it seems to be there since |
Ok, I see. Then I'd be happy to accept a PR for this, if you want to give it a go. The main requirement is that the dashboard should still work in three cases: embedded in Phoenix, embedded in another Plug router, and standalone. |
I'm currently working on a similar "embed into some phoenix/plug app" tool than this one. In my research I found in bamboos preview router that they use
conn.script_name
to construct their routes. It would be nice to use this here as well, so the namespace option is no longer needed.The text was updated successfully, but these errors were encountered: