Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic action spaces does not correctly handle operators_as_actions=True for stochastic domains #81

Open
RushangKaria opened this issue Nov 7, 2023 · 0 comments

Comments

@RushangKaria
Copy link

RushangKaria commented Nov 7, 2023

Description

Currently, using dynamic_action_space=True in conjunction with operators_as_actions=True for a domain does not correctly work for stochastic domains such as Triangle Tireworld in their original IPPC variants i.e. without the custom pddlgym mods.

The issue is the following line of code (

if dynamic_action_space:
)

        if dynamic_action_space:
            if self.domain.operators_as_actions and self._domain_is_strips:
                self._action_space = LiteralActionSpace(
                    self.domain, self.action_predicates,
                    type_hierarchy=self.domain.type_hierarchy,
                    type_to_parent_types=self.domain.type_to_parent_types)

LiteralActionSpace uses FastDownward (FD) for initializing the action space and thus does not support stochastic domains.
The check should also check if sefl.domain.is_probabilistic is set to False.

Error

The error is usually parser errors such as undefined predicate (probabilistic which is understandable since FD tries to parse those keywords as predicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant