Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block alignments don't appear in Layout menu when enabled via theme.json #1089

Closed
grahammtbr opened this issue Jul 25, 2023 · 6 comments
Closed
Labels
bug Bugs, unexpected and weird behaviors
Milestone

Comments

@grahammtbr
Copy link

Hey Tom & Co.,

The move of the alignments (alignwide/full) from the inspector control bar to the Layout menu broke support for when alignment theme support is enabled via theme.json (setting: layout).

For further reference here is my issue from last year when this happened the first time, and I'm guessing could be the issue here.

Thanks,
Graham

@grahammtbr grahammtbr added the triage Awaiting review label Jul 25, 2023
@onetrev
Copy link

onetrev commented Aug 14, 2023

I noticed this too today. In my opinion is this is a pretty major issue, I have a lot of sites out there that can now suddenly not access this functionality unless I go back and edit my custom theme functions. This problem was previously fixed a couple of years ago with this pull request.

@fiveoclock
Copy link

Also experienced the same problem when using GenerateBlocks with any block theme I tried. Alignwide/Full settings are missing under the Layout section.

@syllie
Copy link

syllie commented Aug 28, 2023

+1 Currently building a custom theme, utilizing only theme.json and indeed missing those controls. Mitigating by adding a default WP Group block but this should not be needed.

@diggeddy diggeddy added bug Bugs, unexpected and weird behaviors and removed triage Awaiting review labels Oct 19, 2023
@onetrev
Copy link

onetrev commented Feb 6, 2024

Hey @tomusborne just making sure this doesn't get missed in the GenerateBlocks 1.9 release. It's very annoying, but I know is pretty minor. An end user like myself can fix it like so, but it would be nice to not have to do this. 😁

  // HACK: enable full and wide width alignment (needed due to bug in GenerateBlocks 1.8)
  add_theme_support( 'align-wide' );

@tomusborne tomusborne added this to the 1.9.0 milestone Feb 6, 2024
@tomusborne
Copy link
Owner

This is tough as I'm not finding a way to know if a block theme has enabled support for the align-x classes.

I'll keep digging.

@tomusborne
Copy link
Owner

This is fixed in 1.9.0 (almost in public alpha).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs, unexpected and weird behaviors
Projects
None yet
Development

No branches or pull requests

6 participants