Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Width and Wide Width Alignment options. #1463

Closed
diggeddy opened this issue Nov 8, 2024 · 4 comments
Closed

Full Width and Wide Width Alignment options. #1463

diggeddy opened this issue Nov 8, 2024 · 4 comments
Assignees
Milestone

Comments

@diggeddy
Copy link
Collaborator

diggeddy commented Nov 8, 2024

Description

GB 2.0 does not, currently, have the core Full and Wide Width options.
This needs to be addressed as they are a must for Block Based themes.

Could we:

a) display them if Theme is a Block Theme
b) provide GenerateBlocks > Settings option to enable / disable them

@diggeddy diggeddy added triage Awaiting review discussion and removed triage Awaiting review labels Nov 8, 2024
@iansvo
Copy link
Collaborator

iansvo commented Nov 10, 2024

I 100% agree. I think we can't just pretend those things don't exist, they're a core aspect of the way the editor works, etc. Making it simple to have them fuck off _if desired is definitely a great idea.

Besides, all it does to the actual block is add a class. Seems pretty safe and smart.

@tomusborne
Copy link
Owner

Couple of things to consider here.

  1. Do we simply add support for it, and allow core to insert the UI into the block toolbar?
  2. Do we add an option for it, or simply a filter? For example, GeneratePress could use the filter to turn off this functionality when its in use, as there as much better ways to achieve these layouts.

@diggeddy
Copy link
Collaborator Author

Gut feeling after mulling it over today...
Put them in the sidebar settings like in 1.0 had them
They should go under Settings as they just add the class... but is that exposing them too much ?

Add a bigger notice re: its Theme requirements. If GP is installed we can link to your docs for full width pages.
Add a filter to get rid of them if users want to.

@diggeddy diggeddy changed the title Full Width and Width Alignment options. Full Width and Wide Width Alignment options. Nov 11, 2024
@wpgaurav
Copy link

Yes. Please. Add.

@diggeddy diggeddy added this to the 2.0.0 milestone Dec 2, 2024
@tomusborne tomusborne self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants