Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align wide/full missing when using theme.json #87

Closed
tomusborne opened this issue Aug 3, 2021 · 2 comments
Closed

Align wide/full missing when using theme.json #87

tomusborne opened this issue Aug 3, 2021 · 2 comments
Labels
bug Bugs, unexpected and weird behaviors

Comments

@tomusborne
Copy link
Owner

Description

It's been reported that themes using theme.json do not display the align wide/full option in the Container block.

It seems block themes don't use add_theme_support, which GB depends on checking to add this option: https://fullsiteediting.com/lessons/global-styles/#h-layout-and-content-width

The reason we check for support and add it instead of using the built-in way of adding it is because we don't want Container blocks inside the Grid to have the option.

Steps to reproduce

  1. Add a block theme
  2. Check the Container block for full/wide alignment options.

Expected behavior

The option should appear if the block theme supports it.

Actual behavior

The option doesn't appear.

References:

@tomusborne tomusborne added bug Bugs, unexpected and weird behaviors triage Awaiting review labels Aug 3, 2021
@tomusborne tomusborne added priority: medium and removed triage Awaiting review labels Aug 18, 2021
@tomusborne
Copy link
Owner Author

@illycz
Copy link

illycz commented Sep 30, 2021

I'm using Underscores and experimenting within global styles defined throu theme.json.

When I have theme.json in my theme, align wide and align full options missing in all blocks. I have set theme support for align-wide in functions.php. Options missing also when I set layout settings in theme.json and remove support from functions.php.

It looks like Gutenberg problem...

Any suggestion?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs, unexpected and weird behaviors
Projects
None yet
Development

No branches or pull requests

2 participants