Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction index Uint different in Transaction and Log #335

Closed
brockelmore opened this issue Mar 31, 2020 · 6 comments
Closed

Transaction index Uint different in Transaction and Log #335

brockelmore opened this issue Mar 31, 2020 · 6 comments

Comments

@brockelmore
Copy link
Contributor

Transaction index for a transaction type is Option<U128> but for a log is Option<U256>. These should be consistent
@tomusdrw
Copy link
Owner

PR welcome!

@brockelmore
Copy link
Contributor Author

Do you have a preference if its one way or another? I lean toward U256 but dont really care

@tomusdrw
Copy link
Owner

it's index so it means it's bound by regular computer memory anyway, I would even go as far as making it U64 if that type is available. There should be U64 -> U128 -> U256 conversions in place anyway, right?

@brockelmore
Copy link
Contributor Author

On log, its a straight Option<U256> - no Index. I will update Index to be type U64 and push log to be Index if that is what you think is best?

@tomusdrw
Copy link
Owner

Sounds good!

@brockelmore brockelmore mentioned this issue Mar 31, 2020
Merged
@tomusdrw
Copy link
Owner

tomusdrw commented Apr 2, 2020

Closed via #336

@tomusdrw tomusdrw closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomusdrw @brockelmore