You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
If op is zero, then the message is a "simple transfer message with comment". The comment is contained in the remainder of the message body (without any query_id field, i.e., starting from the fifth byte). If it does not begin with the byte 0xff, the comment is a text one; ... On the other hand, if the comment begins with the byte 0xff, the remainder is a "binary comment"
In other words, need bytes 0x00000000FF before writing buffer
Another issue is handling big binary comments which don't into one cell.
The case of big messages is handled in for text comments in CommentMessage.ts, but not for binary comments.
The text was updated successfully, but these errors were encountered:
Hello! Thank you for your contribution, but in our library BinaryMessage does not a "binary comment" from original whitepaper, but a simple wrapper on top of a buffer and simply a convenient way to write a buffer using messages.
Also we haven't seen binary comments in practice. We are looking to improve this part in next releases.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In: https://github.com/tonwhales/ton/blob/master/src/messages/BinaryMessage.ts
binary comments are not handled according to guidelines: https://ton.org/docs/#/howto/smart-contract-guidelines
In other words, need bytes 0x00000000FF before writing buffer
Suggested fix:
Another issue is handling big binary comments which don't into one cell.
The case of big messages is handled in for text comments in CommentMessage.ts, but not for binary comments.
The text was updated successfully, but these errors were encountered: