Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Italic "<!--" and "-->" not aligned correctly #1008

Closed
sungvzer opened this issue Apr 20, 2020 · 2 comments
Closed

Italic "<!--" and "-->" not aligned correctly #1008

sungvzer opened this issue Apr 20, 2020 · 2 comments

Comments

@sungvzer
Copy link

So when using HTML comments ligatures, i found out that the left one is a few pixels higher than the right one.
I'm actually using Fira Code with Ligatures, and the problem can be found only in the Italic version, as with the normal version this does not occur.
image
Italic

image
Normal
@tonsky
Copy link
Owner

tonsky commented Apr 20, 2020

Should’ve been handled in #917. Please update to the latest version.

@sungvzer
Copy link
Author

sungvzer commented May 5, 2020

Updating to latest version fixed this.
Closing

@sungvzer sungvzer closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonsky @sungvzer