Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ligatures code #1355

Open
2 tasks
tonsky opened this issue Jan 18, 2022 · 1 comment
Open
2 tasks

Simplify ligatures code #1355

tonsky opened this issue Jan 18, 2022 · 1 comment
Milestone

Comments

@tonsky
Copy link
Owner

tonsky commented Jan 18, 2022

Originally Fira Code uses scheme with spacer + single-space ligature that extends beyond its bounding box:

Screenshot 2022-01-18 at 14 11 47

This was done to allow editors to “step inside” the ligature.

Since the original release, many editors now acknowledge the existence of ligatures and don’t need that trick. Maybe ligature code could be simplified?

Potential upsides:

photo_2022-01-18 14 15 07

Questions to check:

@tonsky tonsky added this to the 7 milestone Jan 18, 2022
@tonsky
Copy link
Owner Author

tonsky commented Jan 18, 2022

Another interesting behavior discovered in CoreText.

Screenshot 2022-01-18 at 16 26 03

It feels like < is replaced with > in RTL first, then calt is applied, and then glyphs order is reversed for RTL text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant