Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VF doesn't list weight instances correctly built from script (Win10, others?) #770

Closed
apollolux opened this issue May 27, 2019 · 13 comments
Closed
Labels
Milestone

Comments

@apollolux
Copy link

Hello! Fira Code is a great addition to my dev workflow, especially with its variable weight reducing the need for multiple files. The Fonts listing in Windows 10, however, shows its five defined weight instances as Regular even though they are at different weight values (300, 400, 450, 500, 700). If it's possible to edit the Metadata for the stored instances to reflect their correct names (or at least different ones) please do so, as I have little doubt it's like this in other programs as well.

Fira Code VF 1.207 on Windows 10 Pro (1809) 64-bit

@tonsky
Copy link
Owner

tonsky commented May 28, 2019

wait, VF is a variable font from https://github.com/tonsky/FiraCode/tree/master/distr/variable_ttf right? And it is listed as five separate weights, is that what you are saying? Do you have those weights installed as well? Or just that single TTF?

@apollolux
Copy link
Author

I only have the single TTF (FiraCode-VF.ttf) from that variable_ttf folder installed. When I get back to that comp I'll put up a screenshot.

For what it's worth, I'm pleasantly surprised that Win10 has any support at all for variable fonts, and its pre-installed Bahnschrift variable font does show the correct names for pre-defined weight and width instances.

@tonsky
Copy link
Owner

tonsky commented May 30, 2019

Hmm I don’t see it. Maybe it’s specific to software you are using?

IMG_2669

@apollolux
Copy link
Author

The normal Win10 Fonts listing, finally got screens:

fira-1

fira-2

@apollolux
Copy link
Author

Bahnschrift's listing for comparison:

bahnschrift

@tonsky
Copy link
Owner

tonsky commented Jun 2, 2019

Ok I might take a look but can’t guarantee anything. Is Bahnschrift a variable font as well?

@apollolux
Copy link
Author

Bahnschrift is indeed a variable font, yes.

@apollolux
Copy link
Author

Hi! I just installed v2.000 of the variable Fira Code on a different Windows 10 install and am unfortunately still getting the weights all incorrectly listed as "Regular" in the font info window. Is there a setting in Glyphs where this would be editable? I'm only familiar with FontLab and I don't want to break anything that works by importing and exporting to a potentially wildly different glyphs or ufo file.

@tonsky
Copy link
Owner

tonsky commented Nov 29, 2019

VF is exported through bash scripts https://github.com/tonsky/FiraCode/tree/master/script. Maybe there’s a setting there

@tonsky
Copy link
Owner

tonsky commented Nov 29, 2019

Can you try this file? It was exported from Glyphs directly

FiraCodeGX.ttf.zip

@apollolux
Copy link
Author

apollolux commented Dec 3, 2019

fonts-20191203

The direct-from-Glyphs version does indeed retain the discrete weight instances. For the record, the screenshot shows the 5 correct ones AND the 5 incorrect "Regular" ones because I have both the original VF and the GX versions installed at the same time, not a fault of the GX version at all.

Seems there's something missing in the build script indeed, as it's the only one I see with any reference to building the variable version. Maybe need an updated fontmake or gftools or there's a command line argument to properly reference the instance names?

@apollolux apollolux changed the title VF doesn't list weight instances correctly (Win10) VF doesn't list weight instances correctly built from script (Win10, others?) Dec 3, 2019
@apollolux
Copy link
Author

For what it's worth, Inter (formerly Inter UI) seems to have the same build issue - rsms/inter#142 .

@tonsky tonsky added this to the 3 milestone Jan 22, 2020
@tonsky tonsky added the bug label Jan 22, 2020
@tonsky tonsky modified the milestones: 3, 4 Apr 9, 2020
@tonsky tonsky modified the milestones: 4, 5 May 16, 2020
@tonsky
Copy link
Owner

tonsky commented Jun 7, 2020

Should be solved in d413865

@tonsky tonsky closed this as completed Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants