Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABI] add API to convert SV* to i_color, i_fcolor for use in typemaps and internally #497

Open
tonycoz opened this issue Jun 10, 2022 · 1 comment

Comments

@tonycoz
Copy link
Owner

tonycoz commented Jun 10, 2022

I'm considering changing the way i_color/i_fcolor objects are stored in perl land as objects, currently they're done as PTROBJs, but this is complex to duplicate across perl thread creation, so we currently don't try, using CLONE_SKIP.

The new form will store the i_color/i_fcolor struct as the PV part of an SV which will then be cloned across thread creation like any other perl SV.

Unfortunately this doesn't work for more complex types like images, fills.

@tonycoz tonycoz moved this to Todo in Imager ABI re-work Aug 25, 2022
@tonycoz tonycoz moved this from Todo to Postponed in Imager ABI re-work Aug 25, 2022
@tonycoz
Copy link
Owner Author

tonycoz commented Aug 25, 2022

Postponed for now, this will require incompatible changes between allocating i_color objects and Imager::Color objects that would lead to leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Postponed
Development

No branches or pull requests

1 participant