Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

Updating github.com/aws/aws-sdk-go is painful #400

Open
freeformz opened this issue Jan 19, 2016 · 5 comments
Open

Updating github.com/aws/aws-sdk-go is painful #400

freeformz opened this issue Jan 19, 2016 · 5 comments

Comments

@freeformz
Copy link

When libraries remove (or rename) packages it can be difficult to update them. An example of this is github.com/aws/aws-sdk-go.

Internally we have some software that uses aws-sdk-go and wanted to upgrade from 661aeb3339ad9bd5fd420752ebf18a651d40413e to 727e1f596b6b59700b4d286af9ca41747066685d.

This required a restore, wipe of Godeps/ and then a new save to accomplish instead of a simple godep update github.com/aws/aws-sdk-go/....

This is confusing to most people I've talked to. I think we can do better.

@kevinburkeshyp
Copy link

@freeformz running into this same problem... just want to be sure, the recommended/only workaround is to blow away Godeps?

@freeformz
Copy link
Author

@kevinburkeshyp do a restore, re-save without -r (or -r=false) to remove any rewrites if you have them and then blow away ./Godeps, then checkout any updated deps you want in your $GOPATH and then godep save everything again.

@freeformz
Copy link
Author

This is also an issue when a package starts importing new packages too. For instance grpc 51d644aca6b8eca07b6bd2f5ea435998bf73fa92 to fea7689493da00c4590150b3534c256a962259d3

@radeksimko
Copy link

I also ran into this. Tried godep update github.com/aws/aws-sdk-go/... and there was no change in the /vendor directory at all. The -v argument returned the following:

godep: not in manifest: github.com/aws/aws-go-sdk/...
godep: no packages can be updated

I just ended up running the following sequence of commands:

godep restore
# Remove all occurrences of `"ImportPath": "github.com/aws/aws-sdk-go/aws` from Godeps/Godeps.json
# Run `git checkout v1.1.15` from `$GOPATH/src/github.com/aws/aws-go-sdk`
godep save ./...

which did update both Godeps/Godeps.json and the /vendor directory.

@garethlewin
Copy link

The solution we have come up with is to cycle between

godep save ./...
godep update github.com/aws/aws-sdk-go/...

until no changes happen in the vendor folder

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants