-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Ubuntu for docker #10100
Switch to Ubuntu for docker #10100
Conversation
Sir-Boops
commented
Feb 23, 2019
- Based on my image Here
- 200~ish MB smaller then the current build ( When built right )
- Build with jemalloc for slightly less ram usage
- /Should/ be an exact drop in replacement ( I've been told by other that switched to using this image that's a complete drop in replacement and I don't see any reason it wouldn't be but another confirmation would be nice 😄 )
- Only real downfall of this image is it has to be built using --squash ( docker beta feature ) or the image size will be huge from all the individual RUNs
Dockerfile
Outdated
RUN chown -R mastodon:mastodon /mastodon | ||
|
||
VOLUME /mastodon/public/system | ||
FROM sirboops/nodejs:8.15.0 as node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why sirboops namespace instead of official images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so everything is built using the same libs
Official images afaik use alpine/Deb not Ubuntu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want everything built here I can switch it over to this
Just means alot longer build times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In for a penny, in for a pound. Let's switch to that. Just to have more confidence over long-term availability of these images.
Updated to build everything locally I haven't tested this exact build on a live server yet but everything built and assets compiled just fine locally 👍 |
Thanks for the work @Sir-Boops. I agree with the local building method over prebaked images :) |