Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Ubuntu for docker #10100

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Switch to Ubuntu for docker #10100

merged 1 commit into from
Feb 24, 2019

Conversation

Sir-Boops
Copy link
Contributor

  • Based on my image Here
  • 200~ish MB smaller then the current build ( When built right )
  • Build with jemalloc for slightly less ram usage
  • /Should/ be an exact drop in replacement ( I've been told by other that switched to using this image that's a complete drop in replacement and I don't see any reason it wouldn't be but another confirmation would be nice 😄 )
  • Only real downfall of this image is it has to be built using --squash ( docker beta feature ) or the image size will be huge from all the individual RUNs

Dockerfile Outdated
RUN chown -R mastodon:mastodon /mastodon

VOLUME /mastodon/public/system
FROM sirboops/nodejs:8.15.0 as node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why sirboops namespace instead of official images?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so everything is built using the same libs

Official images afaik use alpine/Deb not Ubuntu

Copy link
Contributor Author

@Sir-Boops Sir-Boops Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want everything built here I can switch it over to this

Just means alot longer build times

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In for a penny, in for a pound. Let's switch to that. Just to have more confidence over long-term availability of these images.

@Sir-Boops
Copy link
Contributor Author

Updated to build everything locally

I haven't tested this exact build on a live server yet but everything built and assets compiled just fine locally 👍

Dockerfile Outdated Show resolved Hide resolved
@Gargron Gargron merged commit 1dbf993 into mastodon:master Feb 24, 2019
@shleeable
Copy link
Contributor

Thanks for the work @Sir-Boops. I agree with the local building method over prebaked images :)

eai04191 pushed a commit to stellarianetwork/mastodon that referenced this pull request Mar 7, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants