Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mention processing for unknwon accounts on incoming ActivityPub Notes #10125

Merged

Conversation

ClearlyClaire
Copy link
Contributor

::FetchRemoteAccountService is not ActivityPub::FetchRemoteAccountService,
its second argument is the pre-fetched body. Passing id: false actually passed
a Hash as the prefetched body, instead of properly resolving unknown remote
accounts.

…otes

`::FetchRemoteAccountService` is not `ActivityPub::FetchRemoteAccountService`,
its second argument is the pre-fetched body. Passing `id: false` actually passed
a `Hash` as the prefetched body, instead of properly resolving unknown remote
accounts.
@ClearlyClaire
Copy link
Contributor Author

Another solution would be to revert ef69c65 I guess. I'm not sure exactly what it solves?

@Gargron
Copy link
Member

Gargron commented Feb 27, 2019

I'm not sure exactly what it solves?

href is not id, therefore it's not necessarily the verbatim URI of the account. At least that's what I think it was about. Or maybe I was getting errors about an unknown constant so I fixed it but picked the wrong namespace?

@Gargron Gargron merged commit 9edab46 into mastodon:master Feb 27, 2019
Gargron pushed a commit that referenced this pull request Mar 5, 2019
…otes (#10125)

`::FetchRemoteAccountService` is not `ActivityPub::FetchRemoteAccountService`,
its second argument is the pre-fetched body. Passing `id: false` actually passed
a `Hash` as the prefetched body, instead of properly resolving unknown remote
accounts.
@ClearlyClaire ClearlyClaire deleted the fixes/create-mention-resolving branch March 14, 2019 13:15
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…otes (mastodon#10125)

`::FetchRemoteAccountService` is not `ActivityPub::FetchRemoteAccountService`,
its second argument is the pre-fetched body. Passing `id: false` actually passed
a `Hash` as the prefetched body, instead of properly resolving unknown remote
accounts.
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
…otes (mastodon#10125)

`::FetchRemoteAccountService` is not `ActivityPub::FetchRemoteAccountService`,
its second argument is the pre-fetched body. Passing `id: false` actually passed
a `Hash` as the prefetched body, instead of properly resolving unknown remote
accounts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants