Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP signature keyId to request log #11591

Merged
merged 1 commit into from
Aug 18, 2019
Merged

Add HTTP signature keyId to request log #11591

merged 1 commit into from
Aug 18, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Aug 17, 2019 •
edited
Loading

Also, the stoplight was not handling OpenSSL::SSL::SSLError exceptions.

@ClearlyClaire
Copy link
Contributor

When would this actually log anything?
Am I right to understand this would only log tracebacks and such, which you appear to have removed in #11590?

@Gargron
Copy link
Member Author

Gargron commented Aug 18, 2019

No, it's part of the request log--path, format, time spent in db etc.

@Gargron Gargron merged commit 1bc077d into master Aug 18, 2019
@Gargron Gargron deleted the fix-log-key-id branch August 18, 2019 16:03
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@Gargron @hiyuki2578
Add HTTP signature keyId to request log (mastodon#11591)
863128b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gargron @ClearlyClaire @ykzts