Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignoring whole status because of one invalid hashtag #11621

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Fix ignoring whole status because of one invalid hashtag #11621

merged 1 commit into from
Aug 19, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Aug 19, 2019

Fix #11618

@Gargron Gargron added the activitypub Protocol-related changes, federation label Aug 19, 2019
@Gargron Gargron mentioned this pull request Aug 19, 2019
Closed
@Gargron Gargron merged commit dff46b2 into master Aug 19, 2019
@Gargron Gargron deleted the fix-11618 branch August 19, 2019 18:36
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@Gargron @hiyuki2578
Fix ignoring whole status because of one invalid hashtag (mastodon#11621
d77a675 
)

Fix mastodon#11618
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this pull request Nov 21, 2019
@ClearlyClaire
Revert "Fix ignoring whole status because of one invalid hashtag (mas…
0c298bf 
…todon#11621)"

This reverts commit dff46b2.
@ClearlyClaire ClearlyClaire mentioned this pull request Nov 21, 2019
Merged
Gargron pushed a commit that referenced this pull request Dec 17, 2019
@ClearlyClaire @Gargron
Fixes featured hashtag setting page erroring out instead of rejecting…
da2143b 
… invalid tags (#12436)

* Revert "Fix ignoring whole status because of one invalid hashtag (#11621)"

This reverts commit dff46b2.

* Fix statuses being rejected because of invalid hashtag names

* Add spec for invalid hashtag names in statuses

* Add test for featured tags controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
activitypub Protocol-related changes, federation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't recognize PeerTube posts with hashtags containing invalid characters
2 participants
@Gargron @ykzts