Change window resize handler to switch to/from mobile layout as soon as needed #11656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
requested changes
Aug 25, 2019
ClearlyClaire
force-pushed
the
fixes/layout-change-reactivity
branch
from
61aa870
to
1970b17
Compare
Gargron
approved these changes
Aug 25, 2019
ykzts
approved these changes
Aug 25, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until this PR, window resizing events were handled half a second after the last resizing event, which makes the UI feels laggy when changing screen orientation are reducing the window size.
As it is unlikely that a string of resize events will cross the mobile threshold repeatedly, apply layout changes as soon as crossing that threshold, and otherwise keep delaying height cache clearing to half a second after the last resizing event.