Change dashboard to short number notation #11847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can skip the setting part. Make it always use short notation with full notation in |
|
I agree. Let's make a simple change. |
noellabo
changed the title
Gargron
reviewed
Sep 15, 2019
| @@ -7,4 +7,8 @@ def feature_hint(feature, enabled) | |||
|
|
|||
| safe_join([feature, content_tag(:span, indicator, class: class_names)]) | |||
| end | |||
|
|
|||
| def short_number_format(number) | |||
| number_to_human number, units: { unit: '', thousand: 'K', million: 'M', billion: 'B' } | |||
There was a problem hiding this comment.
Why is this necessary? Followers count on profile pages already uses short number format
There was a problem hiding this comment.
It existed for switching between short and full notation. Match the way you write your profile page.
Gargron
approved these changes
Sep 15, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Add short numeric notation to the dashboard * Fix i18n * Fix to embed units in code * Remove settings and always use short notation * Remove misplaced test lines * Fit to other pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number on the dashboard overflows on the smartphone.
It is especially useful if the number of digits in interactions this week is large and you can switch to a short notation.